Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Add PyAEDT examples #219

Merged
merged 22 commits into from
Aug 29, 2024
Merged

FEAT: Add PyAEDT examples #219

merged 22 commits into from
Aug 29, 2024

Conversation

Samuelopez-ansys
Copy link
Member

Pull Request Template

Description

Please provide a brief description of the changes in this pull request.

Checklist

Please complete the following checklist before submitting your pull request:

  • I have followed the example template and guide lines to add/update an example.
  • I have tested the example locally and verified that it is working with the latest version of AEDT.
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.

@Samuelopez-ansys Samuelopez-ansys linked an issue Aug 27, 2024 that may be closed by this pull request
Add example 05_electrothermal_analysis.py in HFSS3D Layout #130
Closed
@github-actions github-actions bot added documentation Improvements or additions to documentation bug Something isn't working labels Aug 27, 2024
@Samuelopez-ansys Samuelopez-ansys linked an issue Aug 27, 2024 that may be closed by this pull request
EXAMPLE: new Multiphysics example needs to be added to this repo #167
Closed
@Samuelopez-ansys Samuelopez-ansys marked this pull request as ready for review August 27, 2024 22:05
gmalinve
gmalinve reviewed Aug 28, 2024
View reviewed changes
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) August 28, 2024 20:27
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) August 29, 2024 21:24
SMoraisAnsys
SMoraisAnsys approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job

@Samuelopez-ansys Samuelopez-ansys merged commit 2b5294b into main Aug 29, 2024
11 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/examples_structure branch August 29, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmalinve gmalinve gmalinve left review comments

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78 maxcapodi78 is a code owner

@Devin-Crawford Devin-Crawford Awaiting requested review from Devin-Crawford

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
3 participants
@Samuelopez-ansys @gmalinve @SMoraisAnsys