Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge magnetomotive examples in one #246

Closed
wants to merge 3 commits into from
Closed

merge magnetomotive examples in one #246

wants to merge 3 commits into from

Conversation

gmalinve
Copy link
Collaborator

Pull Request Template

Description

Please provide a brief description of the changes in this pull request.

Checklist

Please complete the following checklist before submitting your pull request:

  • I have followed the example template and guide lines to add/update an example.
  • I have tested the example locally and verified that it is working with the latest version of AEDT.
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.

@gmalinve gmalinve requested review from PipKat and anur7 September 24, 2024 13:22
@github-actions github-actions bot added the bug Something isn't working label Sep 24, 2024
@gmalinve gmalinve changed the title merge examples in one merge magnetomotive examples in one Sep 24, 2024
@gmalinve gmalinve linked an issue Sep 24, 2024 that may be closed by this pull request
Unify magnetomotive force examples #236
Closed
Samuelopez-ansys
Samuelopez-ansys previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@gmalinve gmalinve marked this pull request as draft September 24, 2024 13:28
anur7
anur7 previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@anur7 anur7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :)

@gmalinve gmalinve dismissed stale reviews from anur7 and Samuelopez-ansys via 57c39a2 September 24, 2024 14:41
@gmalinve gmalinve marked this pull request as ready for review September 24, 2024 16:16
@Samuelopez-ansys
Copy link
Member

Merged these modifications in my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys left review comments

@anur7 anur7 anur7 left review comments

@SMoraisAnsys SMoraisAnsys Awaiting requested review from SMoraisAnsys SMoraisAnsys is a code owner

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78 maxcapodi78 is a code owner

@PipKat PipKat Awaiting requested review from PipKat

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify magnetomotive force examples
3 participants
@gmalinve @Samuelopez-ansys @anur7