Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add microwave example #301

Merged
merged 11 commits into from
Feb 6, 2025
Merged

Add microwave example #301

merged 11 commits into from
Feb 6, 2025

Conversation

maxcapodi78
Copy link
Collaborator

Pull Request Template

Description

Please provide a brief description of the changes in this pull request.

Checklist

Please complete the following checklist before submitting your pull request:

  • I have followed the example template and guide lines to add/update an example.
  • I have tested the example locally and verified that it is working with the latest version of AEDT.
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) January 29, 2025 10:28
SMoraisAnsys
SMoraisAnsys previously approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some minor comments

@Devin-Crawford Devin-Crawford self-assigned this Jan 29, 2025
@Devin-Crawford
Update microwave_oven.py
76563e7 
Update to match template

- Updated markdown levels to match template.
- Made minor grammar and spelling corrections.
- Changed some names to be more descriptive.
Devin-Crawford and others added 4 commits January 30, 2025 10:21
@Devin-Crawford @SMoraisAnsys
Update examples/high_frequency/multiphysics/microwave_oven.py
64b6256 
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@Devin-Crawford @SMoraisAnsys
Update examples/high_frequency/multiphysics/microwave_oven.py
a3c053b 
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@Devin-Crawford @SMoraisAnsys
Update examples/high_frequency/multiphysics/microwave_oven.py
f3aff15 
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@Samuelopez-ansys
Modify comments
1da4a9f
Samuelopez-ansys
Samuelopez-ansys approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 870c67c into main Feb 6, 2025
11 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the add_microwave_example branch February 6, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devin-Crawford Devin-Crawford Devin-Crawford left review comments

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@SMoraisAnsys SMoraisAnsys SMoraisAnsys left review comments

@gmalinve gmalinve Awaiting requested review from gmalinve gmalinve is a code owner

Assignees

@Devin-Crawford Devin-Crawford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxcapodi78 @Devin-Crawford @Samuelopez-ansys @SMoraisAnsys