Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX:json import error #316

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

FIX:json import error #316

wants to merge 2 commits into from

Conversation

Devin-Crawford
Copy link
Collaborator

  • Fix JSON import error.

Resolve #315

Description

Refactor of file_utils broke an example.

Checklist

Please complete the following checklist before submitting your pull request:

  • I have followed the example template and guide lines to add/update an example.
  • I have tested the example locally and verified that it is working with the latest version of AEDT.
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.

@github-actions github-actions bot added the bug Something isn't working label Mar 4, 2025
@Devin-Crawford
Update touchstone_file.py
3e7f4b0 
- Ignore this file in CI/CD due to incompatibility with Linux.
- Update to match template.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 5, 2025
@Devin-Crawford Devin-Crawford marked this pull request as draft March 6, 2025 00:26
@Devin-Crawford Devin-Crawford mentioned this pull request Mar 6, 2025
Open
2 tasks
@jvela018
Copy link
Collaborator

jvela018 commented Mar 6, 2025

@Devin-Crawford. This is probably related to ansys/pyaedt#5875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoraisAnsys SMoraisAnsys Awaiting requested review from SMoraisAnsys SMoraisAnsys is a code owner

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78 maxcapodi78 is a code owner

@Samuelopez-ansys Samuelopez-ansys Awaiting requested review from Samuelopez-ansys Samuelopez-ansys is a code owner

@gmalinve gmalinve Awaiting requested review from gmalinve gmalinve is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken methods due to refactor.
2 participants
@Devin-Crawford @jvela018