Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Pathlib refactor: circuit.py #5842

Merged
merged 15 commits into from
Mar 7, 2025
Merged

Conversation

anur7
Copy link
Contributor

@anur7 anur7 commented Feb 26, 2025

issue #5180
In this PR Pathlib refactor is done on circuit.py and test_21_Circuit.py
Close #5882

@anur7 anur7 requested review from jvela018 and gmalinve February 26, 2025 17:11
@anur7 anur7 self-assigned this Feb 26, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@anur7 anur7 linked an issue Feb 26, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.91%. Comparing base (4d786bf) to head (83ef076).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5842      +/-   ##
==========================================
- Coverage   84.92%   84.91%   -0.02%     
==========================================
  Files         161      161              
  Lines       62156    62166      +10     
==========================================
+ Hits        52785    52786       +1     
- Misses       9371     9380       +9     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anur7 anur7 marked this pull request as ready for review February 28, 2025 15:41
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @anur7 !

Can you apply the changes I proposed on multiple locations ? I didn't ping every cases as there seemed to be multiples, but the pattern is often the same. For example, converting a variable into Path at the beginning of the method (or early) and then converting it back to str when needed; adding Path as an expected type in the function docstring, ...

anur7 added 2 commits March 3, 2025 10:38
# Conflicts:
#	src/ansys/aedt/core/generic/general_methods.py
@Samuelopez-ansys Samuelopez-ansys merged commit 6dc4852 into main Mar 7, 2025
45 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the pathlib_circuitpy branch March 7, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in test_00_analyze.py/test_08_compute_erl
4 participants