-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR: Pathlib refactor: circuit.py #5842
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5842 +/- ##
==========================================
- Coverage 84.92% 84.91% -0.02%
==========================================
Files 161 161
Lines 62156 62166 +10
==========================================
+ Hits 52785 52786 +1
- Misses 9371 9380 +9 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @anur7 !
Can you apply the changes I proposed on multiple locations ? I didn't ping every cases as there seemed to be multiples, but the pattern is often the same. For example, converting a variable into Path at the beginning of the method (or early) and then converting it back to str when needed; adding Path as an expected type in the function docstring, ...
# Conflicts: # src/ansys/aedt/core/generic/general_methods.py
issue #5180
In this PR Pathlib refactor is done on circuit.py and test_21_Circuit.py
Close #5882