FIX: Licensingclient path update for version 252 #5854
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5854 +/- ##
==========================================
- Coverage 84.92% 83.49% -1.44%
==========================================
Files 161 161
Lines 62156 62159 +3
==========================================
- Hits 52785 51897 -888
- Misses 9371 10262 +891 🚀 New features to boost your workflow:
|
…o licensingclient_path # Conflicts: # src/ansys/aedt/core/generic/general_methods.py
…ttps://github.com/ansys/pyaedt into FIX__Licensing_client_path_update_for_version_252_
…_path_update_for_version_252_ # Conflicts: # src/ansys/aedt/core/generic/general_methods.py
# Conflicts: # src/ansys/aedt/core/generic/general_methods.py
…o licensingclient_path # Conflicts: # src/ansys/aedt/core/generic/general_methods.py
| @@ -948,11 +948,17 @@ def available_license_feature( | |||
| port = name_env[0] | |||
| name = name_env[1] | |||
|
|
|||
| if not input_dir: | |||
| if not input_dir and aedt_versions.latest_version: | |||
There was a problem hiding this comment.
@maxcapodi78 This logic is different than what you proposed. This appears to work for our use case, but is it ok to prefer the latest_version over current_version as we do here?
There was a problem hiding this comment.
I think it's best to favor the latest_version for licensing so this makes sense to me. The tests pass and this fixed the issue we were seeing locally for 25.2.
There was a problem hiding this comment.
Could you update the function by adding an extra parameter instead ? For example use_latest=False.
This would help people working with early dev versions to avoid using that release by default.
| @@ -948,11 +948,17 @@ def available_license_feature( | |||
| port = name_env[0] | |||
| name = name_env[1] | |||
|
|
|||
| if not input_dir: | |||
| if not input_dir and aedt_versions.latest_version: | |||
There was a problem hiding this comment.
Could you update the function by adding an extra parameter instead ? For example use_latest=False.
This would help people working with early dev versions to avoid using that release by default.
| input_dir = Path(aedt_versions.installed_versions[aedt_versions.current_version]) | ||
| else: | ||
| input_dir = Path(input_dir) | ||
|
|
||
| # The licensing client location has changed in the Windows 25R2 AEDT installation. | ||
| if not check_if_path_exists(os.path.join(input_dir, "licensingclient")): | ||
| input_dir = Path(os.path.dirname(input_dir)) |
There was a problem hiding this comment.
I'm not sure to understand how this behave with the following code defining ansysli_util_path. Can you example why, if the path does not exist, it is still used afterward ?
Description
This PR updates PyAEDT for the changed licensingclient folder in release 25.2.
Issue linked
Error for not finding licensingclient folder.
Checklist