Pengeler/laki reqs parameters #547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sys/pyhps into pengeler/laki-reqs-parameters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
=======================================
Coverage 92.45% 92.45%
=======================================
Files 64 64
Lines 2599 2599
=======================================
Hits 2403 2403
Misses 196 196 ☔ View full report in Codecov by Sentry. |
ojkoenig
requested changes
Feb 28, 2025
| StringParameterDefinition(name="tube%s" % i, default="1", value_list=["1", "2", "3"]) | ||
| ) | ||
| str_input_params = project_api.create_parameter_definitions(str_input_params) | ||
|
|
||
| for i in range(1, 22): |
There was a problem hiding this comment.
pi not incremented in this loop
There was a problem hiding this comment.
The diff here looks misleading, in the actual file it's more obvious there is an increment within the loop body:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update examples to reflect new parameter handling in jms.
Related: https://github.com/ansys-internal/rep-job-management/pull/822
Part of: https://github.com/orgs/ansys-internal/projects/12/views/49?pane=issue&itemId=94942861
Checklist