fix: 修复ProFormSelect/LightSelect选中之后没有自动隐藏和fieldProps使用open属性不能效两个问题 #8035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡️ Deploying PR Preview... |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return restProps?.open | ||
| } | ||
| return open; | ||
| }, [open, restProps]) |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8035 +/- ##
==========================================
- Coverage 97.59% 97.58% -0.01%
==========================================
Files 299 299
Lines 9427 9430 +3
Branches 3503 3504 +1
==========================================
+ Hits 9200 9202 +2
- Misses 209 210 +1
Partials 18 18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
此次PR修复了两个问题：
1、ProFormSelect选中某一项之后，下拉框没有自动消失。其实源码中有此逻辑，只不过没有生效，是因为下拉框选中自动消失的逻辑受到了其他代码的影响。我已经在此分支里加了相应的注释，并进行了修复。
2、在使用ProFormSelect组件时，在fieldProps中使用open属性，不生效。但是按照ProComponents官方文档的描述，fieldProps应该与antd中Select组件的props相同。导致源码逻辑与ProComponents官方文档的描述不一致。