Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translators section in About activity #553

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Roboe
Copy link
Contributor

@Roboe Roboe commented Apr 15, 2017

An easy way to appreciate the work translators (including myself) have put into Lightning Browser. OSS is about collaboration, :)

This needs some gradual work before it is ready to merge, though. I'm calling actual translators right here to come and add themselves to the list: @pejakm, @kuc, @ByteHamster, @hereisdennis, @David-Guillot, @M2ck, @valentind44, @MarkThat, @chirs1985, @anthologist, Death Mask Salesman, @takahirom, @rishubil, @zygimantus, @smarquespt and @ageback. Hope I didn't overlooked anyone.

Things they should do:

<!-- Languages -->
    <string name="translators">Application translators</string>
    <string name="language_ar">Arabic</string>
    <string name="language_de">German</string>
    <string name="language_es">Spanish</string>
    <string name="language_fr">French</string>
    <string name="language_gr">Greek</string>
    <string name="language_hu">Hungarian</string>
    <string name="language_it">Italian</string>
    <string name="language_iw">Hebrew</string>
    <string name="language_ja">Japanese</string>
    <string name="language_ko">Korean</string>
    <string name="language_lt">Lithuanian</string>
    <string name="language_pl">Polish</string>
    <string name="language_pt">Portuguese</string>
    <string name="language_ru">Russian</string>
    <string name="language_sr">Serbian</string>
    <string name="language_tr">Turkish</string>
    <string name="language_zh_rCN">Simplified Chinese</string>
    <string name="language_zh_rTW">Traditional Chinese</string>

Don't worry if any of you mess it up with commits or something. I will clean the git history and squash some commits before @anthonycr merge this.

Have a good day!

@ghost
Copy link

ghost commented Apr 15, 2017

But some languages have translations made by multiple people, some were completely rewritten by next person...
BTW It is really necessary? We don't have "application contributors" neither.

@Roboe
Copy link
Contributor Author

Roboe commented Apr 16, 2017

But some languages have translations made by multiple people, some were completely rewritten by next person...

Every person who has contributed in any form could have its name listed, why not? 😊 If there are multiple translators, their names can be comma-separated in the same string: Person 1, person 2. I've seen this behaviour in other apps like Amaze File Manager.

BTW It is really necessary? We don't have "application contributors" neither.

Anyone can do an "Application contributors" section, and it's a good idea, IMO.

I really don't see any argument against listing translators/contributors: it's just a name in About, takes up barely no space and doesn't need any maintenance at all, 😗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants