Skip to content

Commit cf76b7d

Browse files
author
Dušan Markovič
committed
remove custom implementation and use org.apache.commons.lang.math.NumberUtils.isNumber
1 parent 0488f0e commit cf76b7d

File tree

1 file changed

+3
-24
lines changed

1 file changed

+3
-24
lines changed

src/main/java/io/github/delirius325/jmeter/backendlistener/elasticsearch/ElasticSearchMetric.java

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
import org.slf4j.Logger;
2121
import org.slf4j.LoggerFactory;
2222

23+
import static org.apache.commons.lang.math.NumberUtils.isNumber;
24+
2325
public class ElasticSearchMetric {
2426
private static final Logger logger = LoggerFactory.getLogger(ElasticSearchMetric.class);
2527
private SampleResult sampleResult;
@@ -162,7 +164,7 @@ private void addCustomFields(BackendListenerContext context) {
162164

163165
if (!parameterName.startsWith("es.") && context.containsParameter(parameterName)
164166
&& !"".equals(parameter = context.getParameter(parameterName).trim())) {
165-
if (isInteger(parameter)) {
167+
if (isNumber(parameter)) {
166168
addFilteredJSON(parameterName, Long.parseLong(parameter));
167169
} else {
168170
addFilteredJSON(parameterName, parameter);
@@ -280,27 +282,4 @@ public Date getElapsedTime(boolean forBuildComparison) {
280282
}
281283
}
282284

283-
private static boolean isInteger(String str) {
284-
if (str == null) {
285-
return false;
286-
}
287-
int length = str.length();
288-
if (length == 0) {
289-
return false;
290-
}
291-
int i = 0;
292-
if (str.charAt(0) == '-') {
293-
if (length == 1) {
294-
return false;
295-
}
296-
i = 1;
297-
}
298-
for (; i < length; i++) {
299-
char c = str.charAt(i);
300-
if (c < '0' || c > '9') {
301-
return false;
302-
}
303-
}
304-
return true;
305-
}
306285
}

0 commit comments

Comments
 (0)