Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: list frequency of import/export arrows per file node #181

Open
MengLinMaker opened this issue Nov 17, 2024 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@MengLinMaker
Copy link
Contributor

MengLinMaker commented Nov 17, 2024

Summary

For context, I'm using skott to help port libraries between frameworks.
But porting a library with a team requires coordination and prioritisation.

I would like to prioritise files that are imported most frequently so less blockers occur.

Details

Could add a config somewhere to show how frequency of imports/exports per file on each node.

I'd imagine implementation is a matter of changing nodeId or some sort of name to display the number of imports and edges.

Or an alternative UX is to sort each row by number of exports.

Standard questions

Would you consider contributing a PR?

YES

@MengLinMaker MengLinMaker added the enhancement New feature or request label Nov 17, 2024
@MengLinMaker MengLinMaker changed the title List number export arrows and imports per file node Feature request: list number export arrows and imports per file node Nov 17, 2024
@MengLinMaker MengLinMaker changed the title Feature request: list number export arrows and imports per file node Feature request: list frequency of import/export arrows per file node Nov 17, 2024
@antoine-coulon
Copy link
Owner

Hey @MengLinMaker, thanks again for thinking about enhancing the visualization!

frequency of imports/exports per file on each node

Could you please provide an example of what you meant?

@MengLinMaker
Copy link
Contributor Author

MengLinMaker commented Nov 20, 2024

Critical files are imported to other files frequently.
Non-critical files are not imported less frequently.

20241121_010438.jpg

This would be used to indicate which files should be ported with high priority. A number could be added to show how many times a file is imported.

@antoine-coulon
Copy link
Owner

antoine-coulon commented Nov 25, 2024

Hey @MengLinMaker, I can imagine relevant use cases where it would be valuable to have the number of times a given node is directly imported, as a file being imported X times means that a lot of nodes directly rely on it. We could even imagine graph clustering based on that kind of information.

About the exports, it seems like a different kind of information, a node having X exports could have a lot of meanings.

Feel free to open a PR on that topic if you want to!
I would first suggest to have a map of Nodes x Number of times they are directly imported.

Do you have any suggestion for the UI part to make that information accessible?

@MengLinMaker
Copy link
Contributor Author

@antoine-coulon

After giving this some thought, on file selection, the "in/out arrows" should be highlighted in different colours. Then colour coded numbers would quantify number of "in/out arrows" for better clarity as the number of arrows grow and becomes cluttered.

I believe this would improve what could be communicated through the UI.

@antoine-coulon
Copy link
Owner

@MengLinMaker,

As previously said, I can make sense out of in arrows, but still unsure about out arrows (exports). What kind of information you're trying to expose with out arrows? Feel free to open a draft PR if it's more convenient for you, we could use it as a support for the discussion.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants