-
Notifications
You must be signed in to change notification settings - Fork 11
Support crystal 1.0.0 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @erdnaxeli! I opened a PR that will fix this. Please take a look: #18 |
You PR does not fix the constraint on crystal <1 neither the ameba dependency :) |
That said, I updated the PR with both points. Thanks! |
IIRC no specifying a crystal version means "< 1.0" (https://crystal-lang.org/2020/08/20/preparing-our-shards-for-crystal-1.0.html). |
Hi,
In order to support crystal 1 you need to set the supported crystal version in shards.yml to ">=0.3X.0, <2" (by default it assume "<1"). You also need to use ameba from
crystal-ameba/ameba
.The text was updated successfully, but these errors were encountered: