Skip to content

Support crystal 1.0.0 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erdnaxeli opened this issue Apr 7, 2021 · 4 comments
Open

Support crystal 1.0.0 #15

erdnaxeli opened this issue Apr 7, 2021 · 4 comments

Comments

@erdnaxeli
Copy link

Hi,

In order to support crystal 1 you need to set the supported crystal version in shards.yml to ">=0.3X.0, <2" (by default it assume "<1"). You also need to use ameba from crystal-ameba/ameba.

@lbguilherme
Copy link

Hi @erdnaxeli!

I opened a PR that will fix this. Please take a look: #18

@erdnaxeli
Copy link
Author

erdnaxeli commented Aug 23, 2021

You PR does not fix the constraint on crystal <1 neither the ameba dependency :)

@lbguilherme
Copy link

lbguilherme commented Aug 23, 2021

  • https://github.com/veelenga/ameba redirects to https://github.com/crystal-ameba/ameba, so the two are exactly the same and there is no visible difference for the user. The legacy name is supported.
  • shard.yml is not specifying a Crystal version, so by default shards install won't check and it will just work as the actual code compiles fine with Crystal 1+ now.

That said, I updated the PR with both points. Thanks!

@erdnaxeli
Copy link
Author

shard.yml is not specifying a Crystal version, so by default shards install won't check

IIRC no specifying a crystal version means "< 1.0" (https://crystal-lang.org/2020/08/20/preparing-our-shards-for-crystal-1.0.html).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants