Skip to content

Apollo 4 Migration #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cgoller-evia
Copy link

@cgoller-evia cgoller-evia commented Feb 19, 2025

POC Apollo 4 Migration

Initial Effort to implement #93.

Still missing (as far as I can tell):

Any feedback/help is appreciated.

Copy link

sonarqubecloud bot commented Feb 19, 2025

Quality Gate Passed Quality Gate passed

Issues
7 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cgoller-evia cgoller-evia marked this pull request as draft February 19, 2025 12:54
@cgoller-evia
Copy link
Author

Additional Information:
I had to upgrade the ktlint plugin due to an incompatibility issue, which resulted in some formatting changes during the build process.
I initially thought about leaving these changes out, but that would have caused formatting discrepancies as soon as someone else built this branch.
To keep things clean, I’ve isolated all formatting changes in commit 398d3f3.
This way, it’s easy to distinguish between the actual migration changes and the formatting updates.

@aoudiamoncef aoudiamoncef self-requested a review February 19, 2025 18:37
@aoudiamoncef
Copy link
Owner

Hi @cgoller-evia

Thanks for your contribution.

Try to split PR into small tasks

Don't worry about formatting,I'll do with It.

@cgoller-evia
Copy link
Author

Hi @aoudiamoncef,

Can you elaborate on that?
Would you like multiple smaller prs? Or more granular commits? Or just tasks to check? Or something else entirely? 😄

@robp94
Copy link

robp94 commented Apr 17, 2025

Any news on this? At least the code generation looks good.

@cgoller-evia
Copy link
Author

Haven't heard back from @aoudiamoncef yet 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants