Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pull XCom when passing multiple map_indexes #46728

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

insomnes
Copy link
Contributor

This PR adds the ability to pull XCom when passing multiple map_indexes on RuntimeTaskInstance.

  • Update description in doc string
  • Pull XCom for each value from the product of all task ids and map indexes
  • Fix None case for task id
  • Expand original tests

closes: #46665


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@insomnes
Copy link
Contributor Author

insomnes commented Feb 13, 2025

I am still not sure if this is the intended implementation or not, but it is limited by the current execution API restriction of 1 XCom result in response. I didn't touch it to not break anything.

Prints from original DAG example:

    @dag.task
    def xcom_pull(**context):
        ti: TaskInstance = context["ti"]

        # [1, 3, None, None, None, None]
        for x in [
            ti.xcom_pull(task_ids=["identity", "foo", "plusfive"], map_indexes=[0, 2]),
        ]:
            print(x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to pull XCom when passing multiple map_indexes
1 participant