Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set task/dag labels for Dataproc Batch #46781

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ntr
Copy link

@ntr ntr commented Feb 15, 2025


Set task/dag labels for Dataproc Batch
Setting labels airflow-dag and airflow-task using sanitized dag and task id. This should help the users to keep track of historical execution of dataproc serverless batches.

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Feb 15, 2025
Copy link

boring-cyborg bot commented Feb 15, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk force-pushed the batch_set_airflow_labels branch from 7a9ebdd to 83161b4 Compare February 15, 2025 22:12
@michalmodras
Copy link

This looks good to me - @VladaZakharova let's have someone in the team review as well.

@potiuk
Copy link
Member

potiuk commented Feb 17, 2025

Needs rebase :)

@VladaZakharova
Copy link
Contributor

VladaZakharova commented Feb 18, 2025

Looks good to me! (Although needs rebase)
Verified, on UI in Dataproc everything works as expected both in deff and non-deff modes :)

@potiuk Can you please approve and merge, if it looks good to you?

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants