ATLAS-5017: Patch to replace the long strings set in spark_process at… #337
+113
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
approved these changes
Apr 22, 2025
pinal-shah
requested changes
Apr 23, 2025
| @Override | ||
| public void submitVerticesToUpdate(WorkItemManager manager) { | ||
| AtlasGraph graph = getGraph(); | ||
| Iterable<Object> iterable = graph.query().has(Constants.ENTITY_TYPE_PROPERTY_KEY, TYPE_NAME_SPARK_PROCESS).vertexIds(); |
There was a problem hiding this comment.
Will it encounter Out of Memory, if there are large number of spark_process entities and each have huge string?
It loads vertices, before getting vertexIds
Can you use pagination?
| LOG.debug("processItem(typeName={}, vertexId={})", typeName, vertexId); | ||
|
|
||
| try { | ||
| AtlasGraphUtilsV2.setEncodedProperty(vertex, entityType.getVertexPropertyName(ATTR_NAME_DETAILS), null); |
There was a problem hiding this comment.
setEncodedProperty --> will get the property value (huge string) and then set
- can you check for removeProperty?
- getWrappedElement().property(propertyName, null) --> if it allows setting value as null
if above one of the options works without loading the value then, you have to handle usecase where if the property is not present (you can catch exception)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tributes
What changes were proposed in this pull request?
In this fix i have handled existing data with attributes details and sparkplandescription and removed the data from those to avoid OOM errors
How was this patch tested?
Sanity testing,Manual testing