-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Disable logical type cast of fastavro #34603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @claudevdm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
@@ -163,6 +163,8 @@ def __init__( | |||
super().__init__() | |||
self._source = _FastAvroSource( | |||
file_pattern, min_bundle_size, validate=validate) | |||
# Disable fastavro's automatic logical type conversion | |||
fastavro.read.LOGICAL_READERS.clear() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will remove all avro LOGICAL_READERS in both the case where someone outputs as_row, or not meaning whatever the atomic value of the logical type is will be passed and all other info will be lost..
This might break for people who depend on the current LOGICAL_READERS behavior when as_row=False. If we decide to pass timsetamp-millis as integers, a more targeted fix would be to remove the LOGICAL_READER for 'long-timestamp-millis' only if as_row=True.
Also worth considering whether we want to treat the "timestamp-millis" as a Timestamp like mentioned in #31656 (comment).
@Abacn do you have an opinion whether the "timestamp-millis" type should be treated as an integer or a "Timestamp" type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah agree, a generic suggestion is to avoid breaking change to users.
fix #31656
The bug is caused by the fact that when fastavro library read avro file with logicaltype, it will try to cast it to native type in python. For example, when avro field has long type and logical type is
timestamp-millis
, they will try cast orignal timestamp into datetime. Example cast from fastavro is attached in the imageThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.