Skip to content

Fix GCP auth step for GitHub Actions workflows #34624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

Amar3tto
Copy link
Collaborator

@Amar3tto Amar3tto commented Apr 14, 2025

Addresses #30760, #33065, #32161.

Screenshot 2025-04-14 at 15 11 49

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Apr 14, 2025
@Amar3tto Amar3tto marked this pull request as ready for review April 14, 2025 11:12
@Amar3tto Amar3tto requested a review from damccorm April 14, 2025 11:12
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@damccorm damccorm merged commit 7cb43f2 into apache:master Apr 14, 2025
4 checks passed
@Amar3tto
Copy link
Collaborator Author

@damccorm This PR eliminates errors in Auth step, but still not working because of Invalid JWT Signature.
Could you please refresh JSON key and update GCP_SA_KEY secret?

damccorm added a commit that referenced this pull request Apr 14, 2025
@damccorm
Copy link
Contributor

@damccorm This PR eliminates errors in Auth step, but still not working because of Invalid JWT Signature. Could you please refresh JSON key and update GCP_SA_KEY secret?

We can try that. In the meantime, I think we should revert this since it went from sometimes failing to always failing - https://github.com/apache/beam/actions/runs/14446457300/job/40508116220

Revert PR - #34626

@damccorm
Copy link
Contributor

@damccorm This PR eliminates errors in Auth step, but still not working because of Invalid JWT Signature. Could you please refresh JSON key and update GCP_SA_KEY secret?

We can try that. In the meantime, I think we should revert this since it went from sometimes failing to always failing - https://github.com/apache/beam/actions/runs/14446457300/job/40508116220

Revert PR - #34626

Actually, I checked and the JSON key currently in use is still valid. So I do not think that is the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants