UI: Proper explanation for the global setting to avoid ambiguity #10042

Pearl1594 · 2024-12-04T16:10:53Z

Description

Fixes: #10041
This PR provides Proper explanation for the global setting to avoid ambiguity

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2024-12-04T16:12:02Z

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 16.00%. Comparing base (4f3e8e8) to head (d2b2419).
Report is 10 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/resource/ResourceManagerImpl.java	0.00%	2 Missing ⚠️
...java/com/cloud/agent/manager/AgentManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #10042      +/-   ##
============================================
+ Coverage     15.99%   16.00%   +0.01%     
- Complexity    13076    13081       +5     
============================================
  Files          5649     5649              
  Lines        495612   495978     +366     
  Branches      59995    60134     +139     
============================================
+ Hits          79249    79364     +115     
- Misses       407514   407769     +255     
+ Partials       8849     8845       -4

Flag	Coverage Δ
uitests	`4.03% <ø> (+0.02%)`	⬆️
unittests	`16.83% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Pearl1594 · 2024-12-04T16:47:09Z

@blueorangutan package

blueorangutan · 2024-12-04T16:48:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2024-12-04T17:41:27Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

blueorangutan · 2024-12-04T17:52:36Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11714

DaanHoogland

looks mostly good, needs testing

engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql

shwstppr

@Pearl1594 I think if we just do the following change then it should be good enough. In my opinion, global config is largely okay.

ui/src/views/infra/HostEnableDisable.vue

github-actions · 2025-01-06T11:47:17Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

…me-ambiguous-globalsetting

Pearl1594 · 2025-02-12T15:43:24Z

@nvazquez Apologies for the confusion, I had put the wrong name in the PR description - the global setting name has been renamed to kvm.host.auto.enable.disable. I've updated the schema file and fixed merge conflicts

ui/src/views/infra/HostEnableDisable.vue

engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java

blueorangutan · 2025-02-13T11:13:47Z

[SF] Trillian test result (tid-12380)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53266 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10042-t12380-kvm-ol8.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_isolated_network_with_dynamic_routed_mode	`Error`	2.31	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	`Error`	3.41	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	`Error`	3.42	test_ipv4_routing.py
test_01_auto_enable_disable_kvm_host	`Error`	0.07	test_host_control_state.py
test_02_disable_host_overrides_auto_enable_kvm_host	`Error`	0.06	test_host_control_state.py
test_03_enable_host_does_not_override_auto_disable_kvm_host	`Error`	0.07	test_host_control_state.py
test_06_purge_expunged_vm_background_task	`Failure`	393.77	test_purge_expunged_vms.py

shwstppr

@Pearl1594 I guess we're in somewhat agreement that changes should be limited to ui/src/views/infra/HostEnableDisable.vue
Can you please revert other changes and rename the PR title?

ui/src/views/infra/HostEnableDisable.vue

nvazquez

Thanks @Pearl1594 LGTM - just a few non-blocking comments to keep the changes to minimal

engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java

server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

shwstppr

minor suggestions, otherwise code lgtm

engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java

server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

Pearl1594 · 2025-02-13T13:57:13Z

@blueorangutan package

blueorangutan · 2025-02-13T13:58:03Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-02-13T15:10:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12448

Pearl1594 · 2025-02-14T14:12:08Z

@blueorangutan test

blueorangutan · 2025-02-14T14:14:04Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-02-15T06:01:48Z

[SF] Trillian test result (tid-12412)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53507 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10042-t12412-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_09_connectivity_between_network_and_vpc_tier	`Failure`	60.30	test_ipv4_routing.py
test_11_isolated_network_with_dynamic_routed_mode	`Error`	2.32	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	`Error`	3.42	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	`Error`	3.42	test_ipv4_routing.py
test_06_purge_expunged_vm_background_task	`Failure`	401.41	test_purge_expunged_vms.py

engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java

server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

Pearl1594 · 2025-02-18T14:33:28Z

@blueorangutan package

blueorangutan · 2025-02-18T14:34:05Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland

clgtm

sonarqubecloud · 2025-02-18T15:28:57Z

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

blueorangutan · 2025-02-18T15:54:40Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12504

boring-cyborg bot added component:agent component:orchestration labels Dec 4, 2024

Rename ambiguous global setting: enable.kvm.host.auto.enable.disable

425fc95

Pearl1594 force-pushed the rename-ambiguous-globalsetting branch from 18cfe56 to 425fc95 Compare December 4, 2024 16:37

boring-cyborg bot added component:build component:integration labels Dec 4, 2024

Pearl1594 changed the base branch from 4.19 to 4.20 December 4, 2024 16:37

Update name and UI dialog box

544f8d5

boring-cyborg bot added the component:UI label Dec 4, 2024

Pearl1594 requested review from DaanHoogland and nvazquez December 4, 2024 16:45

DaanHoogland linked an issue Dec 5, 2024 that may be closed by this pull request

Confusing dialog text #10041

Open

DaanHoogland added this to the 4.20.1 milestone Dec 5, 2024

DaanHoogland reviewed Dec 5, 2024

View reviewed changes

engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql Outdated Show resolved Hide resolved

shwstppr reviewed Dec 26, 2024

View reviewed changes

ui/src/views/infra/HostEnableDisable.vue Outdated Show resolved Hide resolved

github-actions bot added the status:has-conflicts label Jan 6, 2025

Pearl1594 added 2 commits February 12, 2025 10:38

address comments

c9a9c4b

Merge branch '4.20' of https://github.com/apache/cloudstack into rena…

517ba7c

…me-ambiguous-globalsetting

github-actions bot removed the status:has-conflicts label Feb 12, 2025

Pearl1594 requested review from DaanHoogland and shwstppr February 12, 2025 15:43

Pearl1594 changed the title ~~[WIP] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable~~ Rename ambiguous global setting: enable.kvm.host.auto.enable.disable Feb 12, 2025

Pearl1594 marked this pull request as ready for review February 12, 2025 15:43

nvazquez reviewed Feb 13, 2025

View reviewed changes

ui/src/views/infra/HostEnableDisable.vue Outdated Show resolved Hide resolved

Do not rename the setting

cf66aa2

Pearl1594 requested a review from nvazquez February 13, 2025 01:58

DaanHoogland reviewed Feb 13, 2025

View reviewed changes

engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java Outdated Show resolved Hide resolved

shwstppr reviewed Feb 13, 2025

View reviewed changes

ui/src/views/infra/HostEnableDisable.vue Outdated Show resolved Hide resolved

rever gs name change

c4e4fb9

Pearl1594 changed the title ~~Rename ambiguous global setting: enable.kvm.host.auto.enable.disable~~ UI: Proper explanation for the global setting to avoid ambiguity Feb 13, 2025

Pearl1594 requested a review from shwstppr February 13, 2025 11:33

debug log

6282548

nvazquez approved these changes Feb 13, 2025

View reviewed changes

engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java Outdated Show resolved Hide resolved

server/src/main/java/com/cloud/resource/ResourceManagerImpl.java Outdated Show resolved Hide resolved

revert newline

155665a

shwstppr approved these changes Feb 13, 2025

View reviewed changes

change log statements

04e5a44

Pearl1594 requested a review from DaanHoogland February 14, 2025 14:11

DaanHoogland reviewed Feb 15, 2025

View reviewed changes

engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java Outdated Show resolved Hide resolved

server/src/main/java/com/cloud/resource/ResourceManagerImpl.java Outdated Show resolved Hide resolved

modify logs

d2b2419

Pearl1594 requested a review from DaanHoogland February 18, 2025 14:30

DaanHoogland approved these changes Feb 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI: Proper explanation for the global setting to avoid ambiguity #10042

UI: Proper explanation for the global setting to avoid ambiguity #10042

Pearl1594 commented Dec 4, 2024 •

edited

Loading

codecov bot commented Dec 4, 2024 •

edited

Loading

Pearl1594 commented Dec 4, 2024

blueorangutan commented Dec 4, 2024

sonarqubecloud bot commented Dec 4, 2024

blueorangutan commented Dec 4, 2024

DaanHoogland left a comment

shwstppr left a comment

github-actions bot commented Jan 6, 2025

Pearl1594 commented Feb 12, 2025

blueorangutan commented Feb 13, 2025

shwstppr left a comment

nvazquez left a comment

shwstppr left a comment

Pearl1594 commented Feb 13, 2025

blueorangutan commented Feb 13, 2025

blueorangutan commented Feb 13, 2025

Pearl1594 commented Feb 14, 2025

blueorangutan commented Feb 14, 2025

blueorangutan commented Feb 15, 2025

Pearl1594 commented Feb 18, 2025

blueorangutan commented Feb 18, 2025

DaanHoogland left a comment

sonarqubecloud bot commented Feb 18, 2025

blueorangutan commented Feb 18, 2025

UI: Proper explanation for the global setting to avoid ambiguity #10042

Are you sure you want to change the base?

UI: Proper explanation for the global setting to avoid ambiguity #10042

Conversation

Pearl1594 commented Dec 4, 2024 • edited Loading

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov bot commented Dec 4, 2024 • edited Loading

Codecov Report

Pearl1594 commented Dec 4, 2024

blueorangutan commented Dec 4, 2024

sonarqubecloud bot commented Dec 4, 2024

Quality Gate passed

blueorangutan commented Dec 4, 2024

DaanHoogland left a comment

Choose a reason for hiding this comment

shwstppr left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 6, 2025

Pearl1594 commented Feb 12, 2025

blueorangutan commented Feb 13, 2025

shwstppr left a comment

Choose a reason for hiding this comment

nvazquez left a comment

Choose a reason for hiding this comment

shwstppr left a comment

Choose a reason for hiding this comment

Pearl1594 commented Feb 13, 2025

blueorangutan commented Feb 13, 2025

blueorangutan commented Feb 13, 2025

Pearl1594 commented Feb 14, 2025

blueorangutan commented Feb 14, 2025

blueorangutan commented Feb 15, 2025

Pearl1594 commented Feb 18, 2025

blueorangutan commented Feb 18, 2025

DaanHoogland left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 18, 2025

Quality Gate failed

blueorangutan commented Feb 18, 2025

Pearl1594 commented Dec 4, 2024 •

edited

Loading

codecov bot commented Dec 4, 2024 •

edited

Loading