add use of virsh domifaddr to get VM external DHCP IP

[rg9975]

Description

Adds use of virsh domifaddr command as first choice for finding the external DHCP address of a newly provisioned VM. This command returns address information about all the interfaces when the Qemu OS guest agent is installed within the VM. When this command fails to find the IP, falls back to original behavior of looking at OS disk lease files to find the data.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested locally with VM running Qemu guest agent.

How did you try to break this feature and the system with this change?

Tested with VM having guest agent and not having agent for expected behaviors.

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 15.15%. Comparing base (ae1d7cc) to head (76b34fb).

Files with missing lines	Patch %	Lines
...e/wrapper/LibvirtGetVmIpAddressCommandWrapper.java	0.00%	24 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10376   +/-   ##
=========================================
  Coverage     15.15%   15.15%           
- Complexity    11314    11318    +4     
=========================================
  Files          5413     5413           
  Lines        474670   474692   +22     
  Branches      57890    57897    +7     
=========================================
+ Hits          71943    71954   +11     
- Misses       394680   394689    +9     
- Partials       8047     8049    +2     

Flag	Coverage Δ
uitests	4.29% <ø> (ø)
unittests	15.88% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12436

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12390)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47368 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10376-t12390-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	Failure	0.05	test_ssvm.py
test_04_cpvm_internals	Failure	0.05	test_ssvm.py