Introducing Storage Access Groups for better management for host and storage connections

[harikrishna-patnala]

Description

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 25.93767% with 1402 lines in your changes missing coverage. Please review.

Project coverage is 16.16%. Comparing base (0dcb8da) to head (a3dd0b7).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/resource/ResourceManagerImpl.java	55.79%	206 Missing and 42 partials ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java	0.00%	123 Missing ⚠️
.../storage/datastore/db/PrimaryDataStoreDaoImpl.java	5.42%	122 Missing ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java	50.00%	88 Missing and 34 partials ⚠️
.../src/main/java/com/cloud/host/dao/HostDaoImpl.java	0.00%	61 Missing ⚠️
...orage/dao/StoragePoolAndAccessGroupMapDaoImpl.java	0.00%	51 Missing ⚠️
...mmand/admin/storage/ConfigureStorageAccessCmd.java	0.00%	44 Missing ⚠️
...stack/api/response/StorageAccessGroupResponse.java	0.00%	43 Missing ⚠️
...torage/motion/StorageSystemDataMotionStrategy.java	0.00%	40 Missing ⚠️
...om/cloud/api/query/dao/StoragePoolJoinDaoImpl.java	0.00%	29 Missing ⚠️
... and 58 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10381      +/-   ##
============================================
+ Coverage     16.07%   16.16%   +0.09%     
- Complexity    13189    13320     +131     
============================================
  Files          5664     5672       +8     
  Lines        497599   499728    +2129     
  Branches      60214    60516     +302     
============================================
+ Hits          79983    80802     +819     
- Misses       408666   409843    +1177     
- Partials       8950     9083     +133     

Flag	Coverage Δ
uitests	3.98% <ø> (-0.03%)	⬇️
unittests	17.02% <25.93%> (+0.10%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12435

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12456

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12459

[harikrishna-patnala]

@blueorangutan test

[blueorangutan]

@harikrishna-patnala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12407)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52229 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10381-t12407-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_isolated_network_with_dynamic_routed_mode	Error	2.27	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	1.37	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	1.37	test_ipv4_routing.py
test_06_purge_expunged_vm_background_task	Failure	389.95	test_purge_expunged_vms.py