Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Storage Access Groups for better management for host and storage connections #10381

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Fix duplicate storage access groups

a3dd0b7
Select commit
Loading
Failed to load commit list.
Draft

Introducing Storage Access Groups for better management for host and storage connections #10381

Fix duplicate storage access groups
a3dd0b7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 14, 2025 in 0s

16.16% (+0.09%) compared to 0dcb8da

View this Pull Request on Codecov

16.16% (+0.09%) compared to 0dcb8da

Details

Codecov Report

Attention: Patch coverage is 25.93767% with 1402 lines in your changes missing coverage. Please review.

Project coverage is 16.16%. Comparing base (0dcb8da) to head (a3dd0b7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/com/cloud/resource/ResourceManagerImpl.java 55.79% 206 Missing and 42 partials ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 123 Missing ⚠️
.../storage/datastore/db/PrimaryDataStoreDaoImpl.java 5.42% 122 Missing ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java 50.00% 88 Missing and 34 partials ⚠️
.../src/main/java/com/cloud/host/dao/HostDaoImpl.java 0.00% 61 Missing ⚠️
...orage/dao/StoragePoolAndAccessGroupMapDaoImpl.java 0.00% 51 Missing ⚠️
...mmand/admin/storage/ConfigureStorageAccessCmd.java 0.00% 44 Missing ⚠️
...stack/api/response/StorageAccessGroupResponse.java 0.00% 43 Missing ⚠️
...torage/motion/StorageSystemDataMotionStrategy.java 0.00% 40 Missing ⚠️
...om/cloud/api/query/dao/StoragePoolJoinDaoImpl.java 0.00% 29 Missing ⚠️
... and 58 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #10381      +/-   ##
============================================
+ Coverage     16.07%   16.16%   +0.09%     
- Complexity    13189    13320     +131     
============================================
  Files          5664     5672       +8     
  Lines        497599   499728    +2129     
  Branches      60214    60516     +302     
============================================
+ Hits          79983    80802     +819     
- Misses       408666   409843    +1177     
- Partials       8950     9083     +133

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov