Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys from the rewrited query params of a view should be blank when not specified in the URL #465

Closed
wants to merge 1 commit into from

Conversation

benel
Copy link

@benel benel commented Mar 31, 2017

https://issues.apache.org/jira/browse/COUCHDB-2722

Overview

Test for COUCHDB-2722 bug report.

Testing recommendations

JIRA issue number

COUCHDB-2722

Related Pull Requests

Rebase of #324.

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
  • I will not forget to update rebar.config.script
    with the correct commit hash once this PR get merged.

@wohali wohali changed the title COUCHDB-2722 Keys from the rewrited query params of a view should be blank when not specified in the URL Apr 30, 2017
@wohali
Copy link
Member

wohali commented Apr 30, 2017

HI @benel,

Sorry to be a bother here. You have 2 PRs, apache/couchdb-couch#59 and apache/couchdb-chttpd#36, that need to be merged into this PR as well. CouchDB moved to a monorepo approach.

With the fixes here alongside the test, I'll be able to confirm the correct behaviour with Travis CI and Jenkins, and can +1 your student's patch so we can merge it in.

Really appreciate your help and patience here!

@janl
Copy link
Member

janl commented Oct 8, 2017

re-open if you’re active again.

@janl janl closed this Oct 8, 2017
nickva added a commit to nickva/couchdb that referenced this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants