Skip to content

Ballista client keep blocking when prepare_task_definition or prepare_multi_task_definition fail #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
westhide opened this issue Mar 22, 2025 · 0 comments · May be fixed by #1212
Open
Labels
bug Something isn't working

Comments

@westhide
Copy link
Contributor

westhide commented Mar 22, 2025

Describe the bug
Ballista client keep blocking when prepare_task_definition or prepare_multi_task_definition fail
Relate to #1212

To Reproduce
Steps to reproduce the behavior:
Run the should_support_json_source test in #1212

    // "Error preparing task definition: Unsupported plan and extension codec failed with unsupported plan type: NdJsonExec"
    async fn should_support_json_source(
        #[future(awt)]
        #[case]
        ctx: SessionContext,
        test_data: String,
    ) {
        let result = ctx
            .read_json(&format!("{test_data}/simple.json"), Default::default())
            .await
            .unwrap()
            .collect()
            .await
            .unwrap();

        #[rustfmt::skip]
        let expected = [
            "+---+",
            "| a |",
            "+---+",
            "| 1 |",
            "+---+"
        ];

        assert_batches_eq!(expected, &result);
    }

Expected behavior
should_support_json_source test should pass.

Additional context
This bug cause by ballista_scheduler failed with Error preparing task definition: Unsupported plan and extension codec failed, but the job not cancel after fail, so the client keep waitting.

// "Error preparing task definition: Unsupported plan and extension codec failed with unsupported plan type: NdJsonExec"
@westhide westhide added the bug Something isn't working label Mar 22, 2025
@westhide westhide linked a pull request Mar 22, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant