Add slt tests for datafusion.execution.parquet.coerce_int96 setting
#15723
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @mbutrovich |
alamb
commented
Apr 16, 2025
| query TTT | ||
| describe int96_from_spark | ||
| ---- | ||
| a Timestamp(Nanosecond, None) YES |
There was a problem hiding this comment.
Here is a reproducer showing the type is still reported as nanoseconds
alamb
commented
Apr 16, 2025
| query P | ||
| select * from int96_from_spark | ||
| ---- | ||
| 2024-01-01T20:34:56.123 |
There was a problem hiding this comment.
You can see here the output is incorrect due to the arrow-rs issue, but at least it is clear that the setting the config flag results in something different than the default
|
lgtm |
mbutrovich
approved these changes
Apr 17, 2025
There was a problem hiding this comment.
Thanks for adding this @alamb! I'll look at adding a new one when I fix the complex type issue.
|
Thanks @comphead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Testing a feature using slt tests ensures it is tested end to end
Turns out it was a valuable exercise, I found a bug:
datafusion.execution.parquet.coerce_int96is set, timestamp type is still reported as Timestamp(nanoseconds) #15721What changes are included in this PR?
Add slt tests
Are these changes tested?
They are only tests
Are there any user-facing changes?