test: add fuzz test for doing aggregation with larger than memory groups and sorting with limited memory #15727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rluvaton
changed the title
|
It is really a big coverage improvment for aggr testing! |
|
What I suggest we should do with this PR is
|
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Adding failing tests to show the current problem with aggregation when there is a need for spilling and we can't hold all of the record batches in memory and tests to make sure that the implementation is dynamic based on the available memory
What changes are included in this PR?
Added fuzz tests in aggregation and sorting
Are these changes tested?
Yes, but they all fail currently
Are there any user-facing changes?
No
Requested by @alamb in #15610 (comment)
FYI all of this tests pass on my PR #15700