Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] improve batch mode when streamload failed #560

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

JNSimba
Copy link
Member

@JNSimba JNSimba commented Feb 18, 2025

Proposed changes

Issue Number: close #xxx

Problem Summary:

  1. When the checkpoint is flushed, the buffermap may be empty, but it is also necessary to wait for the load thread to complete.

  2. When the streamload fails, before the flushqueue is cleared. The main thread is blocked at flushQueue.put(buffer); if the streamload fails at this time, the flushqueue will be cleared, and the main thread will be unblocked. Since there is no checkFlushException at this time, the checkpoint may be considered normal, and data may be lost later.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@vinlee19 vinlee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit ab9412d into apache:master Feb 19, 2025
7 checks passed
@JNSimba JNSimba mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants