[Fix] improve batch mode when streamload failed #560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
When the checkpoint is flushed, the buffermap may be empty, but it is also necessary to wait for the load thread to complete.
When the streamload fails, before the flushqueue is cleared. The main thread is blocked at flushQueue.put(buffer); if the streamload fails at this time, the flushqueue will be cleared, and the main thread will be unblocked. Since there is no checkFlushException at this time, the checkpoint may be considered normal, and data may be lost later.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...