Skip to content
This repository has been archived by the owner on Feb 19, 2025. It is now read-only.

Add capability to parse user sessions by browser session, tab session, and url/domain of app #33

Merged
merged 8 commits into from
Mar 11, 2024

Conversation

mdiep-cese
Copy link
Contributor

This ticket address the issue [#27

@EandrewJones EandrewJones self-requested a review February 27, 2024 18:22
@EandrewJones
Copy link
Contributor

The final change here is to move this functionality out of the utils/crud and into it's own, new module called sessions. The session object (dict) is a new unit of observation in distill. The helpers you wrote are all specific to it. As such, we should give them their own directory and files, i.e. distill/sessions/...

To be consistent with the rest of the codebase, the Session object we create really should be it's own class, but for now this is fine.

@EandrewJones EandrewJones force-pushed the feat/parse-user-sessions branch from d08276d to 262fec2 Compare March 7, 2024 21:54
@EandrewJones EandrewJones merged commit 4fc4606 into apache:master Mar 11, 2024
4 checks passed
@EandrewJones EandrewJones deleted the feat/parse-user-sessions branch March 11, 2024 01:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants