This repository has been archived by the owner on Feb 19, 2025. It is now read-only.
38 add support to label logs #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EandrewJones
suggested changes
Jun 27, 2024
EandrewJones
suggested changes
Jul 1, 2024
There was a problem hiding this comment.
Alright, I set up the file this way to help structure things in a digestible way for you, but now we need to actually integrate this into our library. Right now this file lives at examples/labels.py which is actually outside the distill library and therefore won't get bundled up and shipped to users.
So a few things need to happen:
- Pull out the FeatureDefinition class and put it in its own file located at
distill/core/feature_definition.py, you will have to create thecoredirectory. - Pull out the
label_featuresfunction and add it todistill/process/transform.py - We need to take the test cases under
if __name__ == "__main__"and convert them into proper tests. See the code located attests/.
Try to taking a stab at number three on your own. If you need help. Let me know.
EandrewJones
suggested changes
Jul 3, 2024
…, should the label function remain in the transform.py as well?
EandrewJones
suggested changes
Jul 9, 2024
EandrewJones
suggested changes
Jul 15, 2024
tests/test_transform.py
Outdated
Comment on lines
74
to
75
| #file = open(os.path.join(DATA_DIR, "sample_data.json"), "r") | ||
| #logs = json.load(file) |
EandrewJones
approved these changes
Jul 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38 cc @EandrewJones
Should be logs = setup(json_file, "datetime")