-
Notifications
You must be signed in to change notification settings - Fork 27
Feat(now don't need to add so much info for adding a commit): #476
Conversation
…ted commitizen easy to commit fixed #447
Hi @Suvendu-UI, thanks for the PR and your interest in the project! We always welcome contributions. I see this commit is for #447. We encourage discussion prior to opening PRs to help ensure alignment. Per the comments, we felt this issue needs more discussion before acting on a solution:
I would love for you to work with us to find the right solution and help shepherd this PR through. I'll tag you in further discussion on the issue. See here. I'm inclined to make this ticket just for commitizen. |
Hey, @EandrewJones , how are you, i was looking for easier ways to commit the changes without much hecticness involved , i was googling it and got a automated ai which commits instantly which is almost equiv. to commitizen. Here is the link https://github.com/christian-gama/autocommit |
Hi Suvenda,
Flagon is very particular about its dependency footprint. We try to keep
the tree as small as possible and only use well established tools.
Committizen passes that bar, autocommit does not.
Moreover, we believe contributors should write their own commit messages.
Commit messages should be concise, relevant, clear, and consistent in
style. There's no need to try to add AI (extra complexity) for something as
simple as commits.
Best
Evan Jones
Website: www.ea-jones.com
…On Mon, Jul 8, 2024 at 2:14 PM Suvendu-UI ***@***.***> wrote:
Hey, @EandrewJones <https://github.com/EandrewJones> , how are you, i was
looking for easier ways to commit the changes without much hecticness
involved , i was googling it and got a automated ai which commits instantly
which is almost equiv. to commitizen.
Here is the link https://github.com/christian-gama/autocommit
—
Reply to this email directly, view it on GitHub
<#476 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ2T6ANBDCRZXY2XXZYWRVTZLLJJNAVCNFSM6AAAAABKPPOZO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUHA3DQNBTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things.
- For the GitHub action pipeline to succeed, add the new .czrc file to the ignored paths in .licenserc.yaml. Every file that can have a APL 2.0 license header must. In this case, .czrc is JSON, so it cannot have a header and should be ignored.
- This project uses pre-commit hooks to minimize surprise failures from GitHub actions. Please install.
- Ignore the first point because I don't think .czrc is needed. Based on the docs, you should define the commitizen config either in package.json or .czrc. Package.json is preferred to limit root dir clutter.
Thanks for taking interest in our project. Out of curiosity, are you a Google summer of code participant?
Hey @Jyyjy i think i have resolved the requested changes |
@Suvendu-UI There's a tiny conflict that needs to be resolved before we can merge this. You should be able to:
Pinging @Jyyjy for his final look over. |
done all the steps @EandrewJones and @Jyyjy |
@Suvendu-UI There's still a conflict on package-lock.json. Are you sure you've pulled down the most up-to-date changes from the upstream repo, i.e. I see you're working directly off master on your fork (not recommended, but okay for now). That changes the steps slightly. To be more explicit:
|
now all resolved i guess @EandrewJones |
i don't know why but i am unable to pass the npm ci error , i have tried all the possible method reinstalling the package-lock and package file fsversion , can you help me? |
I just got a chance to look into this. I've never seen this issue before 🤯 Let's try a few things:
You may need to delete the |
implementted commitizen easy to commit
fixed #477


