Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docker local setup markdown [#47] #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krishna-dave206
Copy link

Included the steps for setting up the project locally using docker.
fixes #47

@krishna-dave206
Copy link
Author

Hey! @Jyyjy I have added the README file which contains the steps for setting up the project locally using docker.

Copy link
Contributor

@Jyyjy Jyyjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're confused about what this directory is and by extension what information is needed in the readme. And for good reason, you should be able to learn about this directory from the readme, but it's missing a lot of information. Let me take take over this ticket and I'll try and find you a better first issue within the next couple weeks.


```http://localhost:8080```

## Contribution Setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the contribution section? This information isn't specific to this folder and is adding noise.

## Build the Project

```bash
mvn clean install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maven is not used by this project ,and this command will fail. There is no pom.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docker readme
2 participants