reproducible builds - groovydoc 4, profile fixes, and ensuring gradle projects build docs #14710
+120
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that it will remain groovy3 compatible because shell will fail if it isn't.
… for grails-gradle projects
jdaugherty
commented
May 3, 2025
| compileOnly "org.codehaus.groovy:groovy-templates:$GroovySystem.version" | ||
| compileOnly "org.codehaus.groovy:groovy-xml:$GroovySystem.version" | ||
| compileOnly "org.codehaus.groovy:groovy-ant:$GroovySystem.version" | ||
| compileOnly 'org.apache.groovy:groovy' |
There was a problem hiding this comment.
I spoke to @jamesfredley about this change. Since bootstrap is included by both gorm, and core, we should be compiling with 4. We'll know if it breaks b/c shell still uses 3.
jamesfredley
approved these changes
May 3, 2025
|
I'm going to hold off on merging this for a bit. Paul is continuing to investigate the groovy ordering issues and I want to use this PR to easily test the snapshot changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14679