Skip to content

Include initial-default and write-default in repr #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fokko opened this issue Mar 26, 2025 · 3 comments
Open

Include initial-default and write-default in repr #1853

Fokko opened this issue Mar 26, 2025 · 3 comments
Labels

Comments

@Fokko
Copy link
Contributor

Fokko commented Mar 26, 2025

Feature Request / Improvement

Right now we don't show the initial-default and write-default in the repr of the NestedField. This is because we use it internally to deserialize the Iceberg metadata. With V3, this will also be exposed to the user. It would be good to include these in the repr if they are set. This will not change the repr for existing NestedFields, but it will show it for the ones that have an initial default. The first step would be to look into Pydantic if we can make this conditional.

@kevinjqliu kevinjqliu added the V3 label Mar 26, 2025
@guptaakashdeep
Copy link
Contributor

@Fokko Can I take a stab at implementing this ?

@kevinjqliu
Copy link
Contributor

kevinjqliu commented Apr 19, 2025

@guptaakashdeep
Copy link
Contributor

@kevinjqliu I looked into the mentioned PR. I can see Fokko has already finished changes for initial-default. 👍 I see some additional changes for write-default, are we planning to work separately on write-default or it'll be part of same PR ?

If Fokko is already working on write-default, I will follow along the changes as I am still getting familiar with codebase and following such changes will help me understand it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants