Skip to content

Allow casting from StringType to {FloatType,DoubleType} #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fokko opened this issue Apr 15, 2025 · 4 comments · Fixed by #1933
Closed

Allow casting from StringType to {FloatType,DoubleType} #1919

Fokko opened this issue Apr 15, 2025 · 4 comments · Fixed by #1933
Labels
good first issue Good for newcomers

Comments

@Fokko
Copy link
Contributor

Fokko commented Apr 15, 2025

Feature Request / Improvement

Would be nice to allow this:

Image

@guptaakashdeep
Copy link
Contributor

@Fokko I have added these features. Can you please review these once?

Also, while testing this I also noticed, Conversion from DoubleType/FloatType literal to StringType literal fails. is this expected?

@Fokko
Copy link
Contributor Author

Fokko commented Apr 18, 2025

Thanks for picking this up @guptaakashdeep

Also, while testing this I also noticed, Conversion from DoubleType/FloatType literal to StringType literal fails. is this expected?

I don't think we want to convert from float to string since this is pretty uncommon and we might end up with very long strings when there are these typical float rounding issues. If you're interested in more, there are a few more good first issues :)

@guptaakashdeep
Copy link
Contributor

That makes sense..! And yes I am interested in contributing more :) Do you have any Good First Issues in mind that I can pick and fix? @Fokko. What I saw are mostly either being worked by someone or are under discussion.

@Fokko
Copy link
Contributor Author

Fokko commented Apr 19, 2025

@guptaakashdeep Often, folks claim an issue but don't follow through. Feel free to jump on those :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
2 participants