Skip to content

s3.force-virtual-addressing don't work #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 3 tasks
helmiazizm opened this issue Apr 16, 2025 · 0 comments
Closed
1 of 3 tasks

s3.force-virtual-addressing don't work #1922

helmiazizm opened this issue Apr 16, 2025 · 0 comments

Comments

@helmiazizm
Copy link
Contributor

Apache Iceberg version

0.9.0 (latest release)

Please describe the bug 🐞

s3.force-virtual-addressing had a small problem where the condition does not assign the correct value to property_as_bool function, making any values assigned to s3.force-virtual-addressing always False.

Willingness to contribute

  • I can contribute a fix for this bug independently
  • I would be willing to contribute a fix for this bug with guidance from the Iceberg community
  • I cannot contribute a fix for this bug at this time
@helmiazizm helmiazizm mentioned this issue Apr 16, 2025
Merged
Fokko pushed a commit that referenced this issue Apr 17, 2025
@helmiazizm
Fix setting force_virtual_addressing (#1923)
831170d 
<!--
Thanks for opening a pull request!
-->

<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->

# Rationale for this change

This fix addressed issue #1922 and changed the behavior for both
`_oss_fs` and `_s3_fs` to be able to parse `s3.force-virtual-addressing`
correctly.

# Are these changes tested?

No unit tests are given to this change yet

# Are there any user-facing changes?

No

<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@helmiazizm