Add catalog builder trait #1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to use object safety trait, but found a lot limitation which will make the code difficult to use, so I rollback to this version. For a more complete example, see #1231 |
|
I have a new proposal in #1254 |
Xuanwo
reviewed
May 29, 2025
| /// The catalog type that this builder creates. | ||
| type C: Catalog; | ||
| /// Create a new catalog instance. | ||
| fn load( |
There was a problem hiding this comment.
How about simply using async fn? It's not a big thing for us to place with Send I guess.
There was a problem hiding this comment.
We still need Send, otherwise this line can't be compiled.
| /// Create a new catalog instance. | ||
| fn load( | ||
| self, | ||
| name: impl Into<String>, |
There was a problem hiding this comment.
Since name won't be a bottleneck, how about just using &str?
There was a problem hiding this comment.
I still perfer to use this generic given we don't need to worry about object safety things 😄
sdd
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
CatalogBuildertrait. #1254 .What changes are included in this PR?
Add
CatalogBuildertrait.Are these changes tested?
No, empty trait def.