Skip to content

[infra] publish rc to pypi as part of release process #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Jun 17, 2025

Which issue does this PR close?

What changes are included in this PR?

TODO: make sure pypi publishing for RC is set to version number with RC, i.e. 0.6.0rc1

Are these changes tested?

Yes, tested against personal fork.

Tested

  • push invalid tag, i.e. should-not-trigger. ✅ does not trigger the publish job
  • push RC tag, i.e. v0.6.0-rc.1. ✅ triggers publish job and pypi job
  • push release tag, i.e. v0.6.0. ✅ triggers publish job and pypi job

@@ -20,7 +20,9 @@ name: Publish
on:
push:
tags:
- "*"
# Trigger this workflow when tag follows the versioning format: v<major>.<minor>.<patch>-rc.<release_candidate>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

we should publish rc to pypi as part of the release process
1 participant