feat(transaction): Remove current_table, updates, and requirements from Transaction #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTTY
commented
Jun 18, 2025
| while self | ||
| .current_table | ||
| .table | ||
| .metadata() | ||
| .snapshots() | ||
| .any(|s| s.snapshot_id() == snapshot_id) |
There was a problem hiding this comment.
Maybe we should move the generation of snapshot_id to SnapshotProducer::new. The catch of doing this: if retry happens, every attempt will have a different snapshot_id. I have not seen any side effects yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related Issue
Closes:
What changes are included in this PR?
This PR wraps up the effort to make Transaction API + TransactionAction retryable!
With
Transactionholds retryableactions, it no longer needs to hold staging variables likecurrent_table,updates, orrequirements. These can be generated withindo_commit.Are these changes tested?
Existing unit tests