IGNITE-23466 Rework DZM internals #5092
Open
+3,842
−3,549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alievmirza
suggested changes
Feb 7, 2025
There was a problem hiding this comment.
It seems to me that current implementation breaks contract of dataNodes method. Most part of basic tests from DistributionZoneCausalityDataNodesTest do not pass.
I would start review when at least DistributionZoneCausalityDataNodesTest is green on TC, but better to have all tests from distributionzones module become green
alievmirza
reviewed
Feb 12, 2025
| * @param <T> First object. | ||
| * @param <V> Second object. | ||
| */ | ||
| public class Pair<T, V> { |
There was a problem hiding this comment.
This the 4th Pair class in our codebase, while we have IgniteBiTuple
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23466
Removed causality data nodes engine and distribution zone manager logic based on topology augmentation map. Basics of causality data nodes contract is preserved, according to tests.
Added DataNodesManager as a part of distribution zone manager and all logic related on data nodes calculation for distribution zones is now there. Short summary:
For details, see DataNodesManager class and its javadocs.