IGNITE-24365 Implement UpdateMinimumActiveTxBeginTimeReplicaRequest processing for zone replica #5197
Conversation
…e aware of ZonePartitionId
|
|
||
| ObjectIterator<Entry> itr = tablesWithPartitions.int2IntEntrySet().iterator(); | ||
| ObjectIterator<Entry> itr = idsWithPartitions.int2IntEntrySet().iterator(); |
There was a problem hiding this comment.
It's ids because currently it's both table's and zone's ids depending on the feature flag, right?
There was a problem hiding this comment.
Yes, you are right.
| @@ -38,6 +38,7 @@ class CatalogManagerCompactionFacade { | |||
| this.catalogManager = catalogManager; | |||
| } | |||
|
|
|||
| // TODO https://issues.apache.org/jira/browse/IGNITE-22115 Remove this method. | |||
There was a problem hiding this comment.
I'd rather add https://issues.apache.org/jira/browse/IGNITE-22522 instead of epic.
|
|
||
| // The timestamp must increase monotonically, otherwise it will have to be | ||
| // stored on disk so that reordering does not occur after the node is restarted. | ||
| return commandProcessor.apply(cmd); |
There was a problem hiding this comment.
I guess you will need to use ReplicationRaftCommandApplicator from https://github.com/apache/ignite-3/pull/5187/files#diff-6397becb8896f2a259931efbaf51b1d352f12923b707319b6cee2e61d2443805
There was a problem hiding this comment.
Yep, I've seen this pull-request. I will adopt my changes when that one ^ is merged.
| PARTITION_REPLICATION_MESSAGES_FACTORY, | ||
| clockService, | ||
| this::applyCmdWithExceptionHandling | ||
| ); | ||
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<ReplicaResult> invoke(ReplicaRequest request, UUID senderId) { |
There was a problem hiding this comment.
I've expected that you will copy
return ensureReplicaIsPrimary(request)
.thenCompose(res -> processRequest(request, res.get1(), senderId, res.get2()))
.thenApply(res -> {
if (res instanceof ReplicaResult) {
return (ReplicaResult) res;
} else {
return new ReplicaResult(res, null);
}
});
With empty ensureReplicaIsPrimary.
Anyway let's wait for #5187. There are too many clashes for now.
…itionRaftListener
https://issues.apache.org/jira/browse/IGNITE-24365
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes