Skip to content

LIVY-353. Web UI: Added link to Spark UI for Sessions running on Yarn #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ajbozarth
Copy link
Member

PR moved from old repo cloudera/livy#327

LIVY-353

Followup to cloudera/livy#319 adding a link to the Application Id that links to the Spark UI. The link is grabbed from session.appInfo.sparkUiUrl if it exists, otherwise no link is created.

Screenshots

With an appId without link (in this case before the UI is generated):
no-link
With an appId link:
link
What it links to:
spark

@ajbozarth ajbozarth changed the title [LIVY-353] [Web UI] Added link to Spark UI for Sessions running on Yarn LIVY-353. Web UI: Added link to Spark UI for Sessions running on Yarn Jun 29, 2017
@ajbozarth ajbozarth closed this Jun 30, 2017
@ajbozarth ajbozarth reopened this Jun 30, 2017
@codecov-io
Copy link

codecov-io commented Jun 30, 2017

Codecov Report

Merging #4 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #4      +/-   ##
============================================
+ Coverage     70.59%   70.71%   +0.11%     
+ Complexity      730      729       -1     
============================================
  Files            96       96              
  Lines          5153     5153              
  Branches        776      776              
============================================
+ Hits           3638     3644       +6     
+ Misses          999      992       -7     
- Partials        516      517       +1
Impacted Files Coverage Δ Complexity Δ
...n/java/com/cloudera/livy/rsc/driver/RSCDriver.java 76.29% <0%> (-1.3%) 39% <0%> (-2%)
...in/java/com/cloudera/livy/rsc/ContextLauncher.java 83.08% <0%> (+2.48%) 19% <0%> (ø) ⬇️
...m/cloudera/livy/repl/SparkContextInitializer.scala 63.15% <0%> (+3.5%) 0% <0%> (ø) ⬇️
...va/com/cloudera/livy/rsc/rpc/KryoMessageCodec.java 98.11% <0%> (+3.77%) 19% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4758ecd...640f0f5. Read the comment docs.

@jerryshao
Copy link
Contributor

LGTM, merging to master.

@asfgit asfgit closed this in 9d08a58 Jun 30, 2017
@ajbozarth ajbozarth deleted the ui-app-link branch June 30, 2017 18:16
praveen-kanamarlapudi pushed a commit to praveen-kanamarlapudi/incubator-livy that referenced this pull request Jul 7, 2017
PR moved from old repo cloudera/livy#327

[LIVY-353](https://issues.cloudera.org/browse/LIVY-353)

Followup to cloudera/livy#319 adding a link to the Application Id that links to the Spark UI. The link is grabbed from session.appInfo.sparkUiUrl if it exists, otherwise no link is created.

Screenshots

With an appId without link (in this case before the UI is generated):
![no-link](https://cloud.githubusercontent.com/assets/13952758/25873597/0307dd40-34c4-11e7-9993-925cbf7c749b.png)
With an appId link:
![link](https://cloud.githubusercontent.com/assets/13952758/25873599/0454c69a-34c4-11e7-85d2-31ebe993c5a3.png)
What it links to:
![spark](https://cloud.githubusercontent.com/assets/13952758/25873602/05864318-34c4-11e7-8e2c-2222ef7f6116.png)

Author: Alex Bozarth <ajbozart@us.ibm.com>

Closes apache#4 from ajbozarth/ui-app-link.
jahstreet added a commit to RSEnergyGroup/incubator-livy that referenced this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants