Added a fix for column rename in IcebergSchemaSync #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinishjail97
reviewed
May 9, 2025
| @@ -335,6 +335,33 @@ void testAddMapFieldComment() { | |||
| verify(mockUpdateSchema).commit(); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Can we add a unit test which writes an actual iceberg table to a tempDir path? There are many examples in ITConversionController to follow from.
There was a problem hiding this comment.
I will take a look and will add it @vinishjail97
Comment on lines
119
to
124
| // update the name of the column | ||
| if (!latestColumn.name().equals(currentColumn.name())) { | ||
| updates.put( | ||
| latestColumn.fieldId(), | ||
| () -> updateSchema.renameColumn(currentColumn.name(), latestColumn.name())); | ||
| } |
There was a problem hiding this comment.
I think column name should be done after updating the type?
The UT's are failing are probably because of this.
There was a problem hiding this comment.
I moved after updating the type and still it is failing. I will take a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #711