Skip to content

Add additional properties when doing conversion for hudi #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

rahil-c
Copy link
Contributor

@rahil-c rahil-c commented May 12, 2025

What is the purpose of the pull request

This pr fixes several minor issues with the service which were caught in recent manual and integration testing(see IT pr https://github.com/apache/incubator-xtable/pull/716/files), in order to ensure conversion works for hudi and iceberg and with partitioned tables.

Brief change log

  1. When testing conversion for Hudi, ran into a null pointer issue, as its required for hudi to set partition spec, as mentioned in the xtable docs https://xtable.apache.org/docs/how-to. When users are specifying hudi as either source or target they will need to provide partition-spec in the configurations map in the request.
 "configurations" : {"partition-spec" : "..."}
  1. In addition another issue which was caught during IT was that when Iceberg is the source format and Hudi is the target, in our documentation we require that users provide us the data path to where the data files resides in an iceberg table. From our docs we mention the following: https://github.com/apache/incubator-xtable/tree/main?tab=readme-ov-file#running-the-bundled-jar
tableDataPath is an optional field specifying the path to the data files. If not specified, the tableBasePath will be used. For Iceberg source tables, you will need to specify the /data path.

Special note

As a follow up we will need also add these changes(around parition-spec and a source-data-path) to the spec pr here: #715

Verify this pull request

Now when running with this change do not see the issue.

Screenshot 2025-05-12 at 9 01 19 AM

IT test pr when ran locally passes #716

@rahil-c
Copy link
Contributor Author

rahil-c commented May 12, 2025

@vinishjail97

@rahil-c
Copy link
Contributor Author

rahil-c commented May 12, 2025

unit tests in ci seem to be flaky, as the tests failing are not related to this pr and seem to be related to some spark setup.
Screenshot 2025-05-12 at 10 09 30 AM

When i run those unit tests locally they work fine.

Screenshot 2025-05-12 at 10 11 05 AM

@vinishjail97
Copy link
Contributor

The tests are flaky after merging the previous PR for xtable-service-> #704

@rahil-c
Copy link
Contributor Author

rahil-c commented May 26, 2025

@vinishjail97 Are you sure though? Im not too sure why that pr would cause a flaky test behavior for XTableSyncTool since its in another module from the REST service module.

It seems like this change that was merged recently was able to run fine on the CI #669

Ill try inspecting the full raw logs but can we try rerunning the ci again for this pr to see what occurs?

@vinishjail97 vinishjail97 merged commit aa31ae8 into apache:main May 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants