Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR Bump setup-gradle version #18879

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

mumrah
Copy link
Member

@mumrah mumrah commented Feb 12, 2025

No description provided.

@mumrah mumrah requested a review from mimaison February 12, 2025 23:42
@github-actions github-actions bot added build Gradle build or GitHub Actions small Small PRs labels Feb 12, 2025
@mumrah mumrah requested a review from chia7712 February 12, 2025 23:42
@mumrah
Copy link
Member Author

mumrah commented Feb 12, 2025

I noticed our GHA cache is empty. I'd like to see if just upgrading the setup-gradle plugin is enough to fix it.

@chia7712
Copy link
Member

I noticed our GHA cache is empty.

Pardon me, the following message originates from this PR. Is this behavior expected? It appears that the cache key remains unchanged despite the bump in setup-gradle.

Restore Gradle state from cache
  Requesting Gradle User Home with
      key:gradle-home-v1|Linux-X64|validate[b8a35c2f917259958c9abe8f2ff1b5ff]-a4f1b015bf12a5848020f23c9b19dfed36c418f0
      restoreKeys:[gradle-home-v1|Linux-X64|validate[b8a35c2f917259958c9abe8f2ff1b5ff],gradle-home-v1|Linux-X64|validate,gradle-home-v1|Linux-X64]
  Using cache paths: /home/runner/.gradle/caches,/home/runner/.gradle/notifications,/home/runner/.gradle/jdks,/home/runner/.gradle/.setup-gradle
  Warning: Cache not found for keys: gradle-home-v1|Linux-X64|validate[b8a35c2f917259958c9abe8f2ff1b5ff]-a4f1b015bf12a5848020f23c9b19dfed36c418f0, gradle-home-v1|Linux-X64|validate[b8a35c2f917259958c9abe8f2ff1b5ff], gradle-home-v1|Linux-X64|validate, gradle-home-v1|Linux-X64
  Gradle User Home cache not found. Will initialize empty.

@mumrah
Copy link
Member Author

mumrah commented Feb 13, 2025

@chia7712 I don't think a change to the setup-gradle action version will affect the cache keys. Details on how the cache keys are computed can be found here https://github.com/gradle/actions/blob/main/docs/setup-gradle.md#cache-keys

Also, we wouldn't expect to see a PR writing to the cache since we set gradle-cache-read-only: true in the action (only trunk builds write to the cache)

@chia7712
Copy link
Member

@mumrah thanks for your explanation. My main question is: "Why doesn't this PR utilize the cache, despite the cache keys remaining unchanged?" - The other PR having the same cache keys can use the cache to restore the gradle stuff

@mumrah
Copy link
Member Author

mumrah commented Feb 13, 2025

Thanks for the clarification @chia7712. This PR isn't utilizing the cache, because the cache is empty https://github.com/apache/kafka/actions/caches 🥲. I am hoping that bumping the setup-gradle version will fix things

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This PR isn't utilizing the cache, because the cache is empty https://github.com/apache/kafka/actions/caches

That's odd, as the last build of trunk successfully update the Gradle cache.

  Caching Gradle User Home with cache key: gradle-home-v1|Linux-X64|test[188616818c9a3165053ef8704c27b28e]-c2b38503f2901ff3b1e92b99a8527fdc62acb77e
  Using cache paths: /home/runner/.gradle/caches,/home/runner/.gradle/notifications,/home/runner/.gradle/jdks,/home/runner/.gradle/.setup-gradle
  /usr/bin/tar --posix -cf cache.tzst --exclude cache.tzst -P -C /home/runner/work/kafka/kafka --files-from manifest.txt --use-compress-program zstdmt
  Cache Size: ~257 MB (269612194 B)
  Cache saved successfully

I am hoping that bumping the setup-gradle version will fix things

+1000

@mumrah mumrah merged commit d08e6a8 into apache:trunk Feb 13, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Gradle build or GitHub Actions small Small PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants