MINIFICPP-2370 Add support for parameter providers #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordgamez
force-pushed
the
MINIFICPP-2370
branch
2 times, most recently
from
3654aae to
0d9b7b4
Compare
lordgamez
force-pushed
the
MINIFICPP-2370
branch
from
0d9b7b4 to
4deae19
Compare
lordgamez
force-pushed
the
MINIFICPP-2376
branch
from
54a69d0 to
a29feb9
Compare
lordgamez
force-pushed
the
MINIFICPP-2370
branch
from
4deae19 to
2f34533
Compare
fgerlits
reviewed
Jan 13, 2025
libminifi/src/parameter-providers/EnvironmentVariableParameterProvider.cpp
Outdated
Show resolved
Hide resolved
lordgamez
force-pushed
the
MINIFICPP-2370
branch
from
1c0186a to
7c8f3cc
Compare
fgerlits
reviewed
Jan 15, 2025
fgerlits
reviewed
Jan 15, 2025
fgerlits
approved these changes
Jan 15, 2025
lordgamez
force-pushed
the
MINIFICPP-2376
branch
from
a29feb9 to
681f23e
Compare
lordgamez
force-pushed
the
MINIFICPP-2370
branch
from
efe1fd8 to
cc7597a
Compare
lordgamez
force-pushed
the
MINIFICPP-2370
branch
from
cc7597a to
2228878
Compare
szaszm
reviewed
Feb 20, 2025
This was referenced Mar 3, 2025
Open
szaszm
reviewed
Mar 3, 2025
- Add EnvironmentVariableParameterProvider
lordgamez
force-pushed
the
MINIFICPP-2370
branch
from
8bb3d7c to
1151de3
Compare
szaszm
reviewed
Mar 5, 2025
utils/src/utils/Environment.cpp
Outdated
|
|
||
| FreeEnvironmentStringsW(env_strings); | ||
| #else | ||
| for (char **env = environ; *env != nullptr; ++env) { |
There was a problem hiding this comment.
Accessing the environment is not thread safe. This class has a mutex that could maybe work if all reads and write use it.
There was a problem hiding this comment.
Updated in be322be
szaszm
reviewed
Mar 5, 2025
lordgamez
force-pushed
the
MINIFICPP-2370
branch
from
2c8ac67 to
be322be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2370
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.