Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2462 - Divide libminifi #1902

Closed
wants to merge 17 commits into from
Closed

MINIFICPP-2462 - Divide libminifi #1902

wants to merge 17 commits into from

Conversation

adamdebreceni
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@lordgamez lordgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional comments we talked about in person that should be done afterwards in different PRs and should create separate Jira tickets for:

  • we should add Impl suffix to core/* files in future
  • Move core/include/minifi-cpp directory minifi-api/include/minifi-cpp-api and later have a separate minifi-c-api directory for C API
  • remove ThreadedRepository.h from minifi api and replace its usage with core::TraceableResource

Copy link
Member

@martinzink martinzink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've started to implement my new PR-s on top of this.
Dont want to further increase the size of the PR with nitpicks (since you touched almost the whole codebase I think we can skip the clang-tidy fixes aswell)
Great work LGTM 👍 please rebase and fix the rebase issues

Copy link
Member

@szaszm szaszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first bunch

adamdebreceni and others added 5 commits February 10, 2025 12:37
Co-authored-by: Márton Szász <szaszm@apache.org>
Co-authored-by: Márton Szász <szaszm@apache.org>
Co-authored-by: Márton Szász <szaszm@apache.org>
Copy link
Member

@szaszm szaszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two more missing line endings from the end, but otherwise it looks fine

adamdebreceni and others added 2 commits February 13, 2025 13:20
Co-authored-by: Márton Szász <szaszm@apache.org>
Co-authored-by: Márton Szász <szaszm@apache.org>
@fgerlits fgerlits closed this in a2f8851 Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-clang-tidy Skip clang tidy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants