Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2517 Update NiFi version used in tests to version 2.2.0 #1922

Closed
wants to merge 2 commits into from

Conversation

lordgamez
Copy link
Contributor

https://issues.apache.org/jira/browse/MINIFICPP-2517


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@lordgamez lordgamez force-pushed the MINIFICPP-2517 branch 2 times, most recently from aa08ff6 to f615eac Compare January 29, 2025 14:33
@szaszm
Copy link
Member

szaszm commented Jan 29, 2025

Please consider rebasing to the minifi-api branch. I think that will be the main target branch for some time, until we figure out that refactor, and get it merged.

@lordgamez lordgamez changed the base branch from main to minifi-api January 29, 2025 15:39
@lordgamez lordgamez marked this pull request as ready for review January 29, 2025 16:37
@lordgamez lordgamez marked this pull request as draft January 29, 2025 16:38
@lordgamez lordgamez marked this pull request as ready for review January 29, 2025 16:40
@martinzink martinzink added the minifi-api Targets the minifi-api branch label Jan 30, 2025
fgerlits

This comment was marked as resolved.

@lordgamez lordgamez changed the base branch from minifi-api to main February 18, 2025 11:12
@lordgamez lordgamez removed the minifi-api Targets the minifi-api branch label Feb 18, 2025
@szaszm szaszm closed this in 32114f0 Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants