Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2523 Fix Chocolatey package name for m4 #1924

Conversation

fgerlits
Copy link
Contributor

@fgerlits fgerlits commented Feb 5, 2025

If you run the (python) bootstrap script on Windows, and m4 is not already installed, the script tries to install it using Chocolatey. But it used to fail, because the package is called "gnuwin32-m4", not "m4".

https://issues.apache.org/jira/browse/MINIFICPP-2523


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@fgerlits fgerlits added the minifi-api Targets the minifi-api branch label Feb 5, 2025
The m4 package in Chocolatey is called gnuwin32-m4.
@fgerlits fgerlits force-pushed the MINIFICPP-2523_Fix-chocolatey-package-name-for-m4 branch from 9c6ad87 to 7fb1bc5 Compare February 13, 2025 17:38
@fgerlits fgerlits changed the base branch from minifi-api to main February 13, 2025 17:38
@fgerlits fgerlits removed the minifi-api Targets the minifi-api branch label Feb 13, 2025
@szaszm szaszm closed this in f04f222 Feb 18, 2025
@fgerlits fgerlits deleted the MINIFICPP-2523_Fix-chocolatey-package-name-for-m4 branch March 6, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants