MINIFICPP-2522 Various CI improvements #1936
Conversation
| @@ -1,30 +0,0 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one or more | |||
There was a problem hiding this comment.
This use case is already covered by
|
I think we can also remove the ubuntu gcc build job as we have the rocky build job that covers the gcc-x86 build for all default extensions. |
| @@ -69,7 +69,7 @@ class ReadModbusFunction { | |||
| const uint8_t unit_id_; | |||
| }; | |||
|
|
|||
| class ReadCoilStatus final : public ReadModbusFunction { | |||
| class ReadCoilStatus : public ReadModbusFunction { | |||
There was a problem hiding this comment.
Due to a bug in the latest apple clang final classes break dynamic_cast
https://stackoverflow.com/questions/79192304/macos-xcode-16-breaks-dynamic-cast-for-final-types-defined-in-shared-library
Should we -fno-assume-unique-vtables or just remove the finals here (we rely on dynamic_cast for tests only) but this might also come up somewhere that is not covered by tests.
There was a problem hiding this comment.
I think removing final in the affected cases is fine, and better if there are only few cases. -f flags change the compiler in incompatible ways, it's best to avoid them IMO.
| @@ -29,6 +29,7 @@ Feature: Executing Couchbase operations from MiNiFi-C++ | |||
| And a CouchbaseClusterService is setup up with the name "CouchbaseClusterService" | |||
|
|
|||
| And the "success" relationship of the GetFile processor is connected to the PutCouchbaseKey | |||
| And the "failure" relationship of the PutCouchbaseKey processor is connected to the PutCouchbaseKey | |||
There was a problem hiding this comment.
If minifi's docker starts faster than couchbase the PutCouchbaseKey can fail
| env: | ||
| DOCKER_CMAKE_FLAGS: -DDOCKER_VERIFY_THREAD=3 -DUSE_SHARED_LIBS= -DSTRICT_GSL_CHECKS=AUDIT -DCI_BUILD=ON -DENABLE_AWS=ON -DENABLE_KAFKA=ON -DENABLE_MQTT=ON -DENABLE_AZURE=ON -DENABLE_SQL=ON \ | ||
| -DENABLE_SPLUNK=ON -DENABLE_GCP=ON -DENABLE_OPC=ON -DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_KUBERNETES=ON -DENABLE_TEST_PROCESSORS=ON -DENABLE_PROMETHEUS=ON \ | ||
| -DENABLE_ELASTICSEARCH=OFF -DENABLE_GRAFANA_LOKI=ON -DENABLE_COUCHBASE=ON -DDOCKER_BUILD_ONLY=ON | ||
| CCACHE_DIR: ${{ GITHUB.WORKSPACE }}/.ccache |
There was a problem hiding this comment.
This job is not frequent enough to warrant caching
| @@ -359,7 +359,7 @@ TEST_CASE("ConsumeWindowsEventLog prints events in plain text correctly", "[onTr | |||
| CHECK(event.find(R"(Date: )") != std::string::npos); | |||
| CHECK(event.find(R"(Record ID: )") != std::string::npos); | |||
| CHECK(event.find(R"(Event ID: 14985)") != std::string::npos); | |||
| CHECK(event.find(R"(Task Category: N/A)") != std::string::npos); | |||
| CHECK((event.find(R"(Task Category: N/A)") != std::string::npos || event.find(R"(Task Category: None)") != std::string::npos)); | |||
There was a problem hiding this comment.
They changed the wording between win10 and win11
|
why remove ubuntu 24.04 GCC x86_64? |
Seemed redundant, and I cant think of a single time it caught something that the others didnt 😅 |
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.