Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-385: Add unit tests for OpenNLP UIMA component #748

Merged

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Feb 13, 2025

Change

  • adapts and reactivates AnnotatorsInitializationTest by T. Teofili, originally provided in JIRA issue, to execute for all xml descriptors via true ITs
  • converts AnnotatorsInitializationTest to several integration tests executed via Maven failsafe plugin
  • adds Parser.xml to test-descriptors
  • adds more test classes to uima component
  • configures Maven resource filtering for xml test-descriptors
  • moves 'ci' profile to upper-level pom.xml for re-use in uima component
  • adds simplelogger.properties to test resources dir to avoid log spam during build caused by internal UIMA logger config
  • adds missing @Override annotations here and there
  • reorganizes properties section of parent pom.xml, adding comments

Code Coverage (with PR)

Rows: package, class, method, line, branch
CodeCov-withPR

Code Coverage (previously / without PR)

Rows: package, class, method, line, branch
CodeCov-withoutPR

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne added the java Pull requests that update Java code label Feb 13, 2025
@mawiesne mawiesne self-assigned this Feb 13, 2025
@mawiesne mawiesne force-pushed the OPENNLP-385-Add-unit-tests-for-OpenNLP-UIMA-component branch from a1cd791 to 1ef0d9f Compare February 13, 2025 07:28
@mawiesne mawiesne requested a review from tteofili February 13, 2025 07:28
@mawiesne mawiesne force-pushed the OPENNLP-385-Add-unit-tests-for-OpenNLP-UIMA-component branch 4 times, most recently from 6555efd to 59c9b03 Compare February 13, 2025 09:51
Copy link
Contributor

@rzo1 rzo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks.

Only question: Can we add the CDN available annotation to skip in case asf-cdn or sf are unavailable?

- adapts and reactivates AnnotatorsInitializationTest by T. Teofili, originally provided in JIRA issue, to execute for all xml descriptors
- converts AnnotatorsInitializationTest to several integration tests executed via Maven failsafe plugin
- adds Parser.xml to 'test-descriptors'
- adds more test classes
- configures Maven resource filtering for xml 'test-descriptors'
- moves 'ci' profile to upper-level pom.xml for re-use in opennlp-uima component
- adds simplelogger.properties to test resources to avoid log spam during build caused by internal UIMA logger config
@mawiesne mawiesne force-pushed the OPENNLP-385-Add-unit-tests-for-OpenNLP-UIMA-component branch from 59c9b03 to 4a89fa3 Compare February 13, 2025 18:53
@mawiesne
Copy link
Contributor Author

CDN

It's reflected via latest commit / push.

@mawiesne mawiesne merged commit 9d1dfa9 into main Feb 14, 2025
10 checks passed
@mawiesne mawiesne deleted the OPENNLP-385-Add-unit-tests-for-OpenNLP-UIMA-component branch February 14, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants